Add IRC URL validator and update communication channel format handling#638
Open
shreyadesai20042009 wants to merge 3 commits intooutreachy:masterfrom
Open
Add IRC URL validator and update communication channel format handling#638shreyadesai20042009 wants to merge 3 commits intooutreachy:masterfrom
shreyadesai20042009 wants to merge 3 commits intooutreachy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Changes Made
validate_irc_urlto validate IRC channel URLsirc://<host>[:port]/<channel>https://webchat.oftc.net/?channels=#channelCommunicationChannelmodel:[channel]→<channel>(now required)✅ Validation Covers
irc://irc.mozilla.org)http://freenode.net)irc://irc.oftc.net/qemu)🧪 Testing
Tested manually using:
full_clean()Valid cases:
irc://irc.freenode.net/#guixirc://irc.mozilla.org:6697/webcompathttps://webchat.oftc.net/?channels=#qemuInvalid cases:
http://freenode.netirc://irc.mozilla.orghttps://google.comirc://irc.oftc.net/qemu📌 Notes
🙌 Ready for Review
Please let me know if any changes or additional edge cases should be handled!